Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 380b33b8 authored by James Simmons's avatar James Simmons Committed by Greg Kroah-Hartman
Browse files

staging: lustre: lustre: fix all less than 0 comparison for unsigned values 



Remove all test of less than zero for unsigned values
found with -Wtype-limits.

Signed-off-by: default avatarJames Simmons <uja.ornl@yahoo.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8843
Reviewed-on: https://review.whamcloud.com/23811


Reviewed-by: default avatarAndreas Dilger <andreas.dilger@intel.com>
Reviewed-by: default avatarJian Yu <jian.yu@intel.com>
Reviewed-by: default avatarDmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: default avatarOleg Drokin <oleg.drokin@intel.com>
Signed-off-by: default avatarJames Simmons <jsimmons@infradead.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ec57d6e6

drivers/staging/lustre/lustre/include/cl_object.h

+1 −1
Original line number Diff line number Diff line
@@ -1358,7 +1358,7 @@ struct cl_2queue { 
/** IO types */

enum cl_io_type {

	/** read system call */

	CIT_READ,

	CIT_READ = 1,

	/** write system call */

	CIT_WRITE,

	/** truncate, utime system calls */

drivers/staging/lustre/lustre/llite/rw.c

+1 −1
Original line number Diff line number Diff line
@@ -115,7 +115,7 @@ void ll_ra_count_put(struct ll_sb_info *sbi, unsigned long len) 


static void ll_ra_stats_inc_sbi(struct ll_sb_info *sbi, enum ra_stat which)

{

	LASSERTF(which >= 0 && which < _NR_RA_STAT, "which: %u\n", which);

	LASSERTF(which < _NR_RA_STAT, "which: %u\n", which);

	lprocfs_counter_incr(sbi->ll_ra_stats, which);

}

drivers/staging/lustre/lustre/lov/lov_object.c

+4 −4
Original line number Diff line number Diff line
@@ -638,7 +638,7 @@ static const struct lov_layout_operations lov_dispatch[] = { 
	enum lov_layout_type		    __llt;		  \

									\

	__llt = __obj->lo_type;					 \

	LASSERT(0 <= __llt && __llt < ARRAY_SIZE(lov_dispatch));	\

	LASSERT(__llt < ARRAY_SIZE(lov_dispatch));		\

	lov_dispatch[__llt].op(__VA_ARGS__);			    \

})
@@ -697,7 +697,7 @@ do { \ 
									\

	lov_conf_freeze(__obj);						\

	__llt = __obj->lo_type;					 \

	LASSERT(0 <= __llt && __llt < ARRAY_SIZE(lov_dispatch));	\

	LASSERT(__llt < ARRAY_SIZE(lov_dispatch));	\

	lov_dispatch[__llt].op(__VA_ARGS__);			    \

	lov_conf_thaw(__obj);						\

} while (0)
@@ -748,13 +748,13 @@ static int lov_layout_change(const struct lu_env *unused, 
	u16 refcheck;

	int rc;



	LASSERT(0 <= lov->lo_type && lov->lo_type < ARRAY_SIZE(lov_dispatch));

	LASSERT(lov->lo_type < ARRAY_SIZE(lov_dispatch));



	env = cl_env_get(&refcheck);

	if (IS_ERR(env))

		return PTR_ERR(env);



	LASSERT(0 <= llt && llt < ARRAY_SIZE(lov_dispatch));

	LASSERT(llt < ARRAY_SIZE(lov_dispatch));



	CDEBUG(D_INODE, DFID " from %s to %s\n",

	       PFID(lu_object_fid(lov2lu(lov))),

drivers/staging/lustre/lustre/mdc/lproc_mdc.c

+1 −1
Original line number Diff line number Diff line
@@ -57,7 +57,7 @@ static ssize_t active_store(struct kobject *kobj, struct attribute *attr, 
	if (rc)

		return rc;



	if (val < 0 || val > 1)

	if (val > 1)

		return -ERANGE;



	/* opposite senses */

drivers/staging/lustre/lustre/osc/osc_cache.c

+4 −3
Original line number Diff line number Diff line
@@ -783,6 +783,7 @@ static struct osc_extent *osc_extent_find(const struct lu_env *env, 
			/* pull ext's start back to cover cur */

			ext->oe_start = cur->oe_start;

			ext->oe_grants += chunksize;

			LASSERT(*grants >= chunksize);

			*grants -= chunksize;



			found = osc_extent_hold(ext);
@@ -790,6 +791,7 @@ static struct osc_extent *osc_extent_find(const struct lu_env *env, 
			/* rear merge */

			ext->oe_end = cur->oe_end;

			ext->oe_grants += chunksize;

			LASSERT(*grants >= chunksize);

			*grants -= chunksize;



			/* try to merge with the next one because we just fill
@@ -819,8 +821,8 @@ static struct osc_extent *osc_extent_find(const struct lu_env *env, 
		/* create a new extent */

		EASSERT(osc_extent_is_overlapped(obj, cur) == 0, cur);

		cur->oe_grants = chunksize + cli->cl_extent_tax;

		LASSERT(*grants >= cur->oe_grants);

		*grants -= cur->oe_grants;

		LASSERT(*grants >= 0);



		cur->oe_state = OES_CACHE;

		found = osc_extent_hold(cur);
@@ -849,7 +851,6 @@ static struct osc_extent *osc_extent_find(const struct lu_env *env, 


out:

	osc_extent_put(env, cur);

	LASSERT(*grants >= 0);

	return found;

}
@@ -1219,8 +1220,8 @@ static int osc_extent_expand(struct osc_extent *ext, pgoff_t index, 


	ext->oe_end = end_index;

	ext->oe_grants += chunksize;

	LASSERT(*grants >= chunksize);

	*grants -= chunksize;

	LASSERT(*grants >= 0);

	EASSERTF(osc_extent_is_overlapped(obj, ext) == 0, ext,

		 "overlapped after expanding for %lu.\n", index);