Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 37a746aa authored by Vinod Koul's avatar Vinod Koul
Browse files

dmaengine: ipu: use return value of request_irq 



Commit - 653e67f7: "dmaengine: inherit debug settings from the subsystem
for subdirectories" introduced debug option for subdirectories too
This exposed issue with ipu driver not using return value

For now just warn users about it

Reported-by: default avatarkbuild test robot <fengguang.wu@intel.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent e2f9922a

drivers/dma/ipu/ipu_idmac.c

+10 −4
Original line number Original line Diff line number Diff line
@@ -1532,11 +1532,17 @@ static int idmac_alloc_chan_resources(struct dma_chan *chan) 
#ifdef DEBUG

#ifdef DEBUG

	if (chan->chan_id == IDMAC_IC_7) {

	if (chan->chan_id == IDMAC_IC_7) {

		ic_sof = ipu_irq_map(69);

		ic_sof = ipu_irq_map(69);

		if (ic_sof > 0)

		if (ic_sof > 0) {

			request_irq(ic_sof, ic_sof_irq, 0, "IC SOF", ichan);

			ret = request_irq(ic_sof, ic_sof_irq, 0, "IC SOF", ichan);

			if (ret)

				dev_err(&chan->dev->device, "request irq failed for IC SOF");

		}

		ic_eof = ipu_irq_map(70);

		ic_eof = ipu_irq_map(70);

		if (ic_eof > 0)

		if (ic_eof > 0) {

			request_irq(ic_eof, ic_eof_irq, 0, "IC EOF", ichan);

			ret = request_irq(ic_eof, ic_eof_irq, 0, "IC EOF", ichan);

			if (ret)

				dev_err(&chan->dev->device, "request irq failed for IC EOF");

		}

	}

	}

#endif

#endif