Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 36e4d882 authored by Heba Aamer's avatar Heba Aamer Committed by Greg Kroah-Hartman
Browse files

staging: rtl8712: fix Prefer ether_addr_copy() over memcpy() 



This patch fixes the following checkpatch.pl warning:
Prefer ether_addr_copy() over memcpy()
if the Ethernet addresses are __aligned(2)

pahole showed that the struct used pnetdev->dev_addr
is aligned to u16.

Moreover mac is a simple array, pdata is a pointer that
starts from an even offset.

Signed-off-by: default avatarHeba Aamer <heba93aamer@gmail.com>
Acked-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8004a0c9

drivers/staging/rtl8712/usb_intf.c

+2 −2
Original line number Diff line number Diff line
@@ -462,7 +462,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf, 
				/* Use the mac address stored in the Efuse

				 * offset = 0x12 for usb in efuse

				 */

				memcpy(mac, &pdata[0x12], ETH_ALEN);

				ether_addr_copy(mac, &pdata[0x12]);

			}

			eeprom_CustomerID = pdata[0x52];

			switch (eeprom_CustomerID) {
@@ -579,7 +579,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf, 
		} else

			dev_info(&udev->dev,

				"r8712u: MAC Address from efuse = %pM\n", mac);

		memcpy(pnetdev->dev_addr, mac, ETH_ALEN);

		ether_addr_copy(pnetdev->dev_addr, mac);

	}

	/* step 6. Load the firmware asynchronously */

	if (rtl871x_load_fw(padapter))