Commit 3694bfbd authored Nov 07, 2015 by Markus Elfring Committed by David S. Miller Nov 07, 2015

dwc_eth_qos: Delete an unnecessary check before the function call "of_node_put"



The of_node_put() function tests whether its argument is NULL
and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 40baec22

drivers/net/ethernet/synopsys/dwc_eth_qos.c

+1 −2

Original line number	Original line	Diff line number	Diff line
	@@ -2970,7 +2970,6 @@ static int dwceqos_probe(struct platform_device *pdev)
	err_out_clk_dis_aper:		err_out_clk_dis_aper:
	clk_disable_unprepare(lp->apb_pclk);		clk_disable_unprepare(lp->apb_pclk);
	err_out_free_netdev:		err_out_free_netdev:
	if (lp->phy_node)
	of_node_put(lp->phy_node);		of_node_put(lp->phy_node);
	free_netdev(ndev);		free_netdev(ndev);
	platform_set_drvdata(pdev, NULL);		platform_set_drvdata(pdev, NULL);