Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 36829306 authored by Pekka Enberg's avatar Pekka Enberg Committed by Dave Jones
Browse files

[CPUFREQ] Fix memory leaks in pcc_cpufreq_do_osc 



If acpi_evaluate_object() function call doesn't fail, we must kfree()
output.buffer before returning from pcc_cpufreq_do_osc().

Signed-off-by: default avatarPekka Enberg <penberg@cs.helsinki.fi>
Acked-by: default avatarDavid Rientjes <rientjes@google.com>
Signed-off-by: default avatarDave Jones <davej@redhat.com>
parent 86cf1474

arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c

+12 −6
Original line number Diff line number Diff line
@@ -368,16 +368,22 @@ static int __init pcc_cpufreq_do_osc(acpi_handle *handle) 
		return -ENODEV;



	out_obj = output.pointer;

	if (out_obj->type != ACPI_TYPE_BUFFER)

		return -ENODEV;

	if (out_obj->type != ACPI_TYPE_BUFFER) {

		ret = -ENODEV;

		goto out_free;

	}



	errors = *((u32 *)out_obj->buffer.pointer) & ~(1 << 0);

	if (errors)

		return -ENODEV;

	if (errors) {

		ret = -ENODEV;

		goto out_free;

	}



	supported = *((u32 *)(out_obj->buffer.pointer + 4));

	if (!(supported & 0x1))

		return -ENODEV;

	if (!(supported & 0x1)) {

		ret = -ENODEV;

		goto out_free;

	}



out_free:

	kfree(output.pointer);