Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3618acab authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Mauro Carvalho Chehab
Browse files

[media] cx23885: Replace memcpy with struct assignment 

This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarEzequiel Garcia <elezegarcia@gmail.com>
Reviewed-by: default avatarAndy Walls <awalls@md.metrocast.net>
Signed-off-by: default avatarAndy Walls <awalls@md.metrocast.net>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent b5237747

drivers/media/pci/cx23885/cx23885-video.c

+1 −2
Original line number Diff line number Diff line
@@ -1819,8 +1819,7 @@ int cx23885_video_register(struct cx23885_dev *dev) 
	spin_lock_init(&dev->slock);



	/* Initialize VBI template */

	memcpy(&cx23885_vbi_template, &cx23885_video_template,

		sizeof(cx23885_vbi_template));

	cx23885_vbi_template = cx23885_video_template;

	strcpy(cx23885_vbi_template.name, "cx23885-vbi");



	dev->tvnorm = cx23885_video_template.current_norm;

drivers/media/pci/cx23885/cx23888-ir.c

+2 −4
Original line number Diff line number Diff line
@@ -1237,13 +1237,11 @@ int cx23888_ir_probe(struct cx23885_dev *dev) 
		cx23888_ir_write4(dev, CX23888_IR_IRQEN_REG, 0);



		mutex_init(&state->rx_params_lock);

		memcpy(&default_params, &default_rx_params,

		       sizeof(struct v4l2_subdev_ir_parameters));

		default_params = default_rx_params;

		v4l2_subdev_call(sd, ir, rx_s_parameters, &default_params);



		mutex_init(&state->tx_params_lock);

		memcpy(&default_params, &default_tx_params,

		       sizeof(struct v4l2_subdev_ir_parameters));

		default_params = default_tx_params;

		v4l2_subdev_call(sd, ir, tx_s_parameters, &default_params);

	} else {

		kfifo_free(&state->rx_kfifo);