Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 35eda92a authored by Alexander Usyskin's avatar Alexander Usyskin Committed by Greg Kroah-Hartman
Browse files

mei: amthif: use mei_cl_alloc_cb for allocating cbs 



Use mei_cl_alloc_cb wrapper instead of open code steps

Signed-off-by: default avatarAlexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: default avatarTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 22393381

drivers/misc/mei/amthif.c

+3 −13
Original line number Diff line number Diff line
@@ -196,17 +196,10 @@ static int mei_amthif_read_start(struct mei_cl *cl, const struct file *file) 
{

	struct mei_device *dev = cl->dev;

	struct mei_cl_cb *cb;

	int rets;



	cb = mei_io_cb_init(cl, MEI_FOP_READ, file);

	if (!cb) {

		rets = -ENOMEM;

		goto err;

	}



	rets = mei_io_cb_alloc_buf(cb, mei_cl_mtu(cl));

	if (rets)

		goto err;

	cb = mei_cl_alloc_cb(cl, mei_cl_mtu(cl), MEI_FOP_READ, file);

	if (!cb)

		return -ENOMEM;



	list_add_tail(&cb->list, &dev->ctrl_wr_list.list);
@@ -214,9 +207,6 @@ static int mei_amthif_read_start(struct mei_cl *cl, const struct file *file) 
	dev->iamthif_fp = cb->fp;



	return 0;

err:

	mei_io_cb_free(cb);

	return rets;

}



/**