Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 34a55d5e authored by Bjørn Mork's avatar Bjørn Mork Committed by David S. Miller
Browse files

net: qmi_wwan: ignore bogus CDC Union descriptors



The CDC descriptors found on these vendor specific functions should
not be considered authoritative.  They seem to be ignored by drivers
for other systems, and the quality is therefore low.

One device (1e0e:9001) has been reported to have such a bogus union
descriptor on the QMI function, making it fail probing even if the
device id was dynamically added.  The report was not complete enough
to allow adding a device entry for this modem. But this should at
least fix the dynamic id probing problem.

Reported-by: default avatarKanerva Topi <Topi.Kanerva@cinia.fi>
Signed-off-by: default avatarBjørn Mork <bjorn@mork.no>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 270c499f
Loading
Loading
Loading
Loading
+4 −1
Original line number Diff line number Diff line
@@ -374,7 +374,10 @@ static int qmi_wwan_bind(struct usbnet *dev, struct usb_interface *intf)
				"bogus CDC Union: master=%u, slave=%u\n",
				cdc_union->bMasterInterface0,
				cdc_union->bSlaveInterface0);
			goto err;

			/* ignore and continue... */
			cdc_union = NULL;
			info->data = intf;
		}
	}