Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 341604ad authored by Richard Fitzgerald's avatar Richard Fitzgerald Committed by Mark Brown
Browse files

ASoC: arizona: fix range of OPCLK_REF 



The code was able to generate illegal OPCLK_REF values because the
reference frequency tables listed all values of SYSCLK instead of
valid values for OPCLK_REF clock. The maximum OPCLK_REF clock is
49.152MHz or 45.1584MHz.

Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.wolfsonmicro.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 6ff33f39

sound/soc/codecs/arizona.c

+5 −11
Original line number Diff line number Diff line
@@ -979,24 +979,18 @@ void arizona_init_dvfs(struct arizona_priv *priv) 
}

EXPORT_SYMBOL_GPL(arizona_init_dvfs);



static unsigned int arizona_sysclk_48k_rates[] = {

static unsigned int arizona_opclk_ref_48k_rates[] = {

	6144000,

	12288000,

	24576000,

	49152000,

	73728000,

	98304000,

	147456000,

};



static unsigned int arizona_sysclk_44k1_rates[] = {

static unsigned int arizona_opclk_ref_44k1_rates[] = {

	5644800,

	11289600,

	22579200,

	45158400,

	67737600,

	90316800,

	135475200,

};



static int arizona_set_opclk(struct snd_soc_codec *codec, unsigned int clk,
@@ -1021,11 +1015,11 @@ static int arizona_set_opclk(struct snd_soc_codec *codec, unsigned int clk, 
	}



	if (refclk % 8000)

		rates = arizona_sysclk_44k1_rates;

		rates = arizona_opclk_ref_44k1_rates;

	else

		rates = arizona_sysclk_48k_rates;

		rates = arizona_opclk_ref_48k_rates;



	for (ref = 0; ref < ARRAY_SIZE(arizona_sysclk_48k_rates) &&

	for (ref = 0; ref < ARRAY_SIZE(arizona_opclk_ref_48k_rates) &&

		     rates[ref] <= refclk; ref++) {

		div = 1;

		while (rates[ref] / div >= freq && div < 32) {