Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3361c7be authored by Jeffrey Layton's avatar Jeffrey Layton Committed by Linus Torvalds
Browse files

make iunique use a do/while loop rather than its obscure goto loop 



A while back, Christoph mentioned that he thought that iunique ought to be
cleaned up to use a more conventional loop construct. This patch does that,
turning the strange goto loop into a do/while.

Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 9d0633cf

fs/inode.c

+10 −14
Original line number Diff line number Diff line
@@ -687,23 +687,19 @@ ino_t iunique(struct super_block *sb, ino_t max_reserved) 
	struct inode *inode;

	struct hlist_head *head;

	ino_t res;



	spin_lock(&inode_lock);

retry:

	if (counter > max_reserved) {

		head = inode_hashtable + hash(sb,counter);

	do {

		if (counter <= max_reserved)

			counter = max_reserved + 1;

		res = counter++;

		head = inode_hashtable + hash(sb, res);

		inode = find_inode_fast(sb, head, res);

		if (!inode) {

	} while (inode != NULL);

	spin_unlock(&inode_lock);

			return res;

		}

	} else {

		counter = max_reserved + 1;

	}

	goto retry;



	return res;

}



EXPORT_SYMBOL(iunique);



struct inode *igrab(struct inode *inode)