Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 31c91319 authored by tangwenji's avatar tangwenji Committed by Greg Kroah-Hartman
Browse files

target: fix null pointer regression in core_tmr_drain_tmr_list 



commit 88fb2fa7db7510bf1078226ab48d162d9854f3d4 upstream.

The target system kernel crash when the initiator executes
the sg_persist -A command,because of the second argument to
be set to NULL when core_tmr_lun_reset is called in
core_scsi3_pro_preempt function.

This fixes a regression originally introduced by:

  commit 51ec502a
  Author: Bart Van Assche <bart.vanassche@sandisk.com>
  Date:   Tue Feb 14 16:25:54 2017 -0800

      target: Delete tmr from list before processing

Signed-off-by: default avatartangwenji <tang.wenji@zte.com.cn>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8009209a

drivers/target/target_core_tmr.c

+2 −1
Original line number Diff line number Diff line
@@ -217,6 +217,7 @@ static void core_tmr_drain_tmr_list( 
	 * LUN_RESET tmr..

	 */

	spin_lock_irqsave(&dev->se_tmr_lock, flags);

	if (tmr)

		list_del_init(&tmr->tmr_list);

	list_for_each_entry_safe(tmr_p, tmr_pp, &dev->dev_tmr_list, tmr_list) {

		cmd = tmr_p->task_cmd;