Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 31770bd4 authored by Daniel Vetter's avatar Daniel Vetter Committed by Eric Anholt
Browse files

drm/i915: don't allow tiling changes on pinned buffers v2 



Makes no sense and complicates matters for pipelined tiling changes.
So don't allow it and return -EBUSY.

v2: Fix reference leak. Thanks to Owain Ainsworth for spotting this.

Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarEric Anholt <eric@anholt.net>
parent 149c36a3

drivers/gpu/drm/i915/i915_gem_tiling.c

+5 −0
Original line number Diff line number Diff line
@@ -283,6 +283,11 @@ i915_gem_set_tiling(struct drm_device *dev, void *data, 
		return -EINVAL;

	}



	if (obj_priv->pin_count) {

		drm_gem_object_unreference_unlocked(obj);

		return -EBUSY;

	}



	if (args->tiling_mode == I915_TILING_NONE) {

		args->swizzle_mode = I915_BIT_6_SWIZZLE_NONE;

		args->stride = 0;