Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 313162d0 authored by Paul Gortmaker's avatar Paul Gortmaker
Browse files

device.h: audit and cleanup users in main include dir



The <linux/device.h> header includes a lot of stuff, and
it in turn gets a lot of use just for the basic "struct device"
which appears so often.

Clean up the users as follows:

1) For those headers only needing "struct device" as a pointer
in fcn args, replace the include with exactly that.

2) For headers not really using anything from device.h, simply
delete the include altogether.

3) For headers relying on getting device.h implicitly before
being included themselves, now explicitly include device.h

4) For files in which doing #1 or #2 uncovers an implicit
dependency on some other header, fix by explicitly adding
the required header(s).

Any C files that were implicitly relying on device.h to be
present have already been dealt with in advance.

Total removals from #1 and #2: 51.  Total additions coming
from #3: 9.  Total other implicit dependencies from #4: 7.

As of 3.3-rc1, there were 110, so a net removal of 42 gives
about a 38% reduction in device.h presence in include/*

Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
parent 51990e82
Loading
Loading
Loading
Loading
+0 −2
Original line number Original line Diff line number Diff line
@@ -25,8 +25,6 @@
#ifndef _SSP_PL022_H
#ifndef _SSP_PL022_H
#define _SSP_PL022_H
#define _SSP_PL022_H


#include <linux/device.h>

/**
/**
 * whether SSP is in loopback mode or not
 * whether SSP is in loopback mode or not
 */
 */
+1 −1
Original line number Original line Diff line number Diff line
@@ -213,7 +213,6 @@ struct atm_cirange {


#ifdef __KERNEL__
#ifdef __KERNEL__


#include <linux/device.h>
#include <linux/wait.h> /* wait_queue_head_t */
#include <linux/wait.h> /* wait_queue_head_t */
#include <linux/time.h> /* struct timeval */
#include <linux/time.h> /* struct timeval */
#include <linux/net.h>
#include <linux/net.h>
@@ -249,6 +248,7 @@ struct k_atm_dev_stats {
	struct k_atm_aal_stats aal5;
	struct k_atm_aal_stats aal5;
};
};


struct device;


enum {
enum {
	ATM_VF_ADDR,		/* Address is in use. Set by anybody, cleared
	ATM_VF_ADDR,		/* Address is in use. Set by anybody, cleared
+2 −1
Original line number Original line Diff line number Diff line
@@ -9,10 +9,11 @@
#ifndef _ATTRIBUTE_CONTAINER_H_
#ifndef _ATTRIBUTE_CONTAINER_H_
#define _ATTRIBUTE_CONTAINER_H_
#define _ATTRIBUTE_CONTAINER_H_


#include <linux/device.h>
#include <linux/list.h>
#include <linux/list.h>
#include <linux/klist.h>
#include <linux/klist.h>


struct device;

struct attribute_container {
struct attribute_container {
	struct list_head	node;
	struct list_head	node;
	struct klist		containers;
	struct klist		containers;
+2 −1
Original line number Original line Diff line number Diff line
@@ -9,11 +9,12 @@
 * the Free Software Foundation
 * the Free Software Foundation
 */
 */


#include <linux/device.h>
#include <linux/kmemcheck.h>
#include <linux/kmemcheck.h>


#define C2PORT_NAME_LEN			32
#define C2PORT_NAME_LEN			32


struct device;

/*
/*
 * C2 port basic structs
 * C2 port basic structs
 */
 */
+0 −1
Original line number Original line Diff line number Diff line
@@ -910,7 +910,6 @@ struct mode_page_header {


#ifdef __KERNEL__
#ifdef __KERNEL__
#include <linux/fs.h>		/* not really needed, later.. */
#include <linux/fs.h>		/* not really needed, later.. */
#include <linux/device.h>
#include <linux/list.h>
#include <linux/list.h>


struct packet_command
struct packet_command
Loading