Commit 30d5b64b authored Aug 18, 2005 by Jaroslav Kysela Committed by Linus Torvalds Aug 18, 2005

[PATCH] broken error path in drivers/pnp/card.c



The error path in pnp_request_card_device() is broken (one variable is
left initialized and the semaphore is not unlocked).

This fixes it (and has been tested).

Signed-off-by: Jaroslav Kysela <perex@suse.cz>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 518e6540

drivers/pnp/card.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -312,6 +312,8 @@ struct pnp_dev * pnp_request_card_device(struct pnp_card_link *clink, const char
		if (drv->link.driver.probe) {
		if (drv->link.driver.probe(&dev->dev)) {
		dev->dev.driver = NULL;
		dev->card_link = NULL;
		up_write(&dev->dev.bus->subsys.rwsem);
		return NULL;
		}
		}