Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 309c675e authored by Julia Lawall's avatar Julia Lawall Committed by Guenter Roeck
Browse files

hwmon: (pcf8591) use permission-specific DEVICE_ATTR variants 



Use DEVICE_ATTR_RW for read/write attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.

The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent d0688f6c

drivers/hwmon/pcf8591.c

+11 −13
Original line number Diff line number Diff line
@@ -103,14 +103,14 @@ show_in_channel(1); 
show_in_channel(2);

show_in_channel(3);



static ssize_t show_out0_ouput(struct device *dev,

static ssize_t out0_output_show(struct device *dev,

				struct device_attribute *attr, char *buf)

{

	struct pcf8591_data *data = i2c_get_clientdata(to_i2c_client(dev));

	return sprintf(buf, "%d\n", data->aout * 10);

}



static ssize_t set_out0_output(struct device *dev,

static ssize_t out0_output_store(struct device *dev,

				 struct device_attribute *attr,

				 const char *buf, size_t count)

{
@@ -132,17 +132,16 @@ static ssize_t set_out0_output(struct device *dev, 
	return count;

}



static DEVICE_ATTR(out0_output, S_IWUSR | S_IRUGO,

		   show_out0_ouput, set_out0_output);

static DEVICE_ATTR_RW(out0_output);



static ssize_t show_out0_enable(struct device *dev,

static ssize_t out0_enable_show(struct device *dev,

				struct device_attribute *attr, char *buf)

{

	struct pcf8591_data *data = i2c_get_clientdata(to_i2c_client(dev));

	return sprintf(buf, "%u\n", !(!(data->control & PCF8591_CONTROL_AOEF)));

}



static ssize_t set_out0_enable(struct device *dev,

static ssize_t out0_enable_store(struct device *dev,

				 struct device_attribute *attr,

				 const char *buf, size_t count)

{
@@ -165,8 +164,7 @@ static ssize_t set_out0_enable(struct device *dev, 
	return count;

}



static DEVICE_ATTR(out0_enable, S_IWUSR | S_IRUGO,

		   show_out0_enable, set_out0_enable);

static DEVICE_ATTR_RW(out0_enable);



static struct attribute *pcf8591_attributes[] = {

	&dev_attr_out0_enable.attr,