Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f1cec32 authored by Vivien Didelot's avatar Vivien Didelot Committed by Jiri Kosina
Browse files

HID: hid-lg4ff: use DEVICE_ATTR_RW macro 



Use the DEVICE_ATTR_RW macro to reduce boiler plate and move the
attribute declaration to get rid of function signatures.

Signed-off-by: default avatarVivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent fcf80e59

drivers/hid/hid-lg4ff.c

+5 −7
Original line number Diff line number Diff line
@@ -49,11 +49,6 @@ 


static void hid_lg4ff_set_range_dfp(struct hid_device *hid, u16 range);

static void hid_lg4ff_set_range_g25(struct hid_device *hid, u16 range);

static ssize_t lg4ff_range_show(struct device *dev, struct device_attribute *attr, char *buf);

static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count);



static DEVICE_ATTR(range, S_IRUGO | S_IWUSR, lg4ff_range_show,

		   lg4ff_range_store);



struct lg4ff_device_entry {

	__u32 product_id;
@@ -417,7 +412,8 @@ static void hid_lg4ff_switch_native(struct hid_device *hid, const struct lg4ff_n 
}



/* Read current range and display it in terminal */

static ssize_t lg4ff_range_show(struct device *dev, struct device_attribute *attr, char *buf)

static ssize_t range_show(struct device *dev, struct device_attribute *attr,

			  char *buf)

{

	struct hid_device *hid = to_hid_device(dev);

	struct lg4ff_device_entry *entry;
@@ -442,7 +438,8 @@ static ssize_t lg4ff_range_show(struct device *dev, struct device_attribute *att 


/* Set range to user specified value, call appropriate function

 * according to the type of the wheel */

static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count)

static ssize_t range_store(struct device *dev, struct device_attribute *attr,

			   const char *buf, size_t count)

{

	struct hid_device *hid = to_hid_device(dev);

	struct lg4ff_device_entry *entry;
@@ -473,6 +470,7 @@ static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *at 


	return count;

}

static DEVICE_ATTR_RW(range);



#ifdef CONFIG_LEDS_CLASS

static void lg4ff_set_leds(struct hid_device *hid, __u8 leds)