Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ed772b7 authored by Roland Dreier's avatar Roland Dreier Committed by Nicholas Bellinger
Browse files

target: Remove unused target_core_fabric_ops.get_fabric_sense_len method 



There are no callers of se_tfo->get_fabric_sense_len(), so we should
stop having every fabric driver implement it.

Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 343d475d

Documentation/target/tcm_mod_builder.py

+0 −8
Original line number Diff line number Diff line
@@ -402,7 +402,6 @@ def tcm_mod_build_configfs(proto_ident, fabric_mod_dir_var, fabric_mod_name): 
	buf += "	.queue_data_in			= " + fabric_mod_name + "_queue_data_in,\n"

	buf += "	.queue_status			= " + fabric_mod_name + "_queue_status,\n"

	buf += "	.queue_tm_rsp			= " + fabric_mod_name + "_queue_tm_rsp,\n"

	buf += "	.get_fabric_sense_len		= " + fabric_mod_name + "_get_fabric_sense_len,\n"

	buf += "	.set_fabric_sense_len		= " + fabric_mod_name + "_set_fabric_sense_len,\n"

	buf += "	.is_state_remove		= " + fabric_mod_name + "_is_state_remove,\n"

	buf += "	/*\n"
@@ -906,13 +905,6 @@ def tcm_mod_dump_fabric_ops(proto_ident, fabric_mod_dir_var, fabric_mod_name): 
			buf += "}\n\n"

			bufi += "int " + fabric_mod_name + "_queue_tm_rsp(struct se_cmd *);\n"



		if re.search('get_fabric_sense_len\)\(', fo):

			buf += "u16 " + fabric_mod_name + "_get_fabric_sense_len(void)\n"

			buf += "{\n"

			buf += "	return 0;\n"

			buf += "}\n\n"

			bufi += "u16 " + fabric_mod_name + "_get_fabric_sense_len(void);\n"



		if re.search('set_fabric_sense_len\)\(', fo):

			buf += "u16 " + fabric_mod_name + "_set_fabric_sense_len(struct se_cmd *se_cmd, u32 sense_length)\n"

			buf += "{\n"

drivers/infiniband/ulp/srpt/ib_srpt.c

+0 −6
Original line number Diff line number Diff line
@@ -3569,11 +3569,6 @@ static u16 srpt_set_fabric_sense_len(struct se_cmd *cmd, u32 sense_length) 
	return 0;

}



static u16 srpt_get_fabric_sense_len(void)

{

	return 0;

}



/**

 * srpt_parse_i_port_id() - Parse an initiator port ID.

 * @name: ASCII representation of a 128-bit initiator port ID.
@@ -3953,7 +3948,6 @@ static struct target_core_fabric_ops srpt_template = { 
	.queue_data_in			= srpt_queue_response,

	.queue_status			= srpt_queue_status,

	.queue_tm_rsp			= srpt_queue_response,

	.get_fabric_sense_len		= srpt_get_fabric_sense_len,

	.set_fabric_sense_len		= srpt_set_fabric_sense_len,

	/*

	 * Setup function pointers for generic logic in

drivers/scsi/qla2xxx/tcm_qla2xxx.c

+0 −7
Original line number Diff line number Diff line
@@ -735,11 +735,6 @@ static int tcm_qla2xxx_queue_tm_rsp(struct se_cmd *se_cmd) 
	return 0;

}



static u16 tcm_qla2xxx_get_fabric_sense_len(void)

{

	return 0;

}



static u16 tcm_qla2xxx_set_fabric_sense_len(struct se_cmd *se_cmd,

					u32 sense_length)

{
@@ -1691,7 +1686,6 @@ static struct target_core_fabric_ops tcm_qla2xxx_ops = { 
	.queue_data_in			= tcm_qla2xxx_queue_data_in,

	.queue_status			= tcm_qla2xxx_queue_status,

	.queue_tm_rsp			= tcm_qla2xxx_queue_tm_rsp,

	.get_fabric_sense_len		= tcm_qla2xxx_get_fabric_sense_len,

	.set_fabric_sense_len		= tcm_qla2xxx_set_fabric_sense_len,

	/*

	 * Setup function pointers for generic logic in
@@ -1740,7 +1734,6 @@ static struct target_core_fabric_ops tcm_qla2xxx_npiv_ops = { 
	.queue_data_in			= tcm_qla2xxx_queue_data_in,

	.queue_status			= tcm_qla2xxx_queue_status,

	.queue_tm_rsp			= tcm_qla2xxx_queue_tm_rsp,

	.get_fabric_sense_len		= tcm_qla2xxx_get_fabric_sense_len,

	.set_fabric_sense_len		= tcm_qla2xxx_set_fabric_sense_len,

	/*

	 * Setup function pointers for generic logic in

drivers/target/iscsi/iscsi_target_configfs.c

+0 −9
Original line number Diff line number Diff line
@@ -1557,14 +1557,6 @@ static u16 lio_set_fabric_sense_len(struct se_cmd *se_cmd, u32 sense_length) 
	return 2;

}



static u16 lio_get_fabric_sense_len(void)

{

	/*

	 * Return two byte offset into allocated sense_buffer.

	 */

	return 2;

}



static int lio_queue_tm_rsp(struct se_cmd *se_cmd)

{

	struct iscsi_cmd *cmd = container_of(se_cmd, struct iscsi_cmd, se_cmd);
@@ -1749,7 +1741,6 @@ int iscsi_target_register_configfs(void) 
	fabric->tf_ops.queue_status = &lio_queue_status;

	fabric->tf_ops.queue_tm_rsp = &lio_queue_tm_rsp;

	fabric->tf_ops.set_fabric_sense_len = &lio_set_fabric_sense_len;

	fabric->tf_ops.get_fabric_sense_len = &lio_get_fabric_sense_len;

	/*

	 * Setup function pointers for generic logic in target_core_fabric_configfs.c

	 */

drivers/target/loopback/tcm_loop.c

+0 −6
Original line number Diff line number Diff line
@@ -851,11 +851,6 @@ static u16 tcm_loop_set_fabric_sense_len(struct se_cmd *se_cmd, u32 sense_length 
	return 0;

}



static u16 tcm_loop_get_fabric_sense_len(void)

{

	return 0;

}



static char *tcm_loop_dump_proto_id(struct tcm_loop_hba *tl_hba)

{

	switch (tl_hba->tl_proto_id) {
@@ -1374,7 +1369,6 @@ static int tcm_loop_register_configfs(void) 
	fabric->tf_ops.queue_status = &tcm_loop_queue_status;

	fabric->tf_ops.queue_tm_rsp = &tcm_loop_queue_tm_rsp;

	fabric->tf_ops.set_fabric_sense_len = &tcm_loop_set_fabric_sense_len;

	fabric->tf_ops.get_fabric_sense_len = &tcm_loop_get_fabric_sense_len;



	/*

	 * Setup function pointers for generic logic in target_core_fabric_configfs.c