Commit 2e106e4d authored Jul 08, 2015 by Jérémy Bobbio Committed by Jonathan Corbet Jul 10, 2015

scripts/kernel-doc: parse kernel-doc deterministically



Regular expressions for highlights in kernel-doc are stored in a Perl
hash.  These hashes are ordered differently for each Perl run. This will
prevent kernel-doc to behave deterministically when parsing “@foo()” as
in some runs it will be interpreted as a parameter and in the others it
will be interpreted as a function.

We now sort the %highlights hash to get the same behavior on every run.

Signed-off-by: Jérémy Bobbio <lunar@debian.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

parent d770e558

scripts/kernel-doc

+1 −1

Original line number	Diff line number	Diff line
		@@ -2587,7 +2587,7 @@ $kernelversion = get_kernel_version();

		# generate a sequence of code that will splice in highlighting information
		# using the s// operator.
		foreach my $pattern (keys %highlights) {
		foreach my $pattern (sort keys %highlights) {
		# print STDERR "scanning pattern:$pattern, highlight:($highlights{$pattern})\n";
		$dohighlight .= "\$contents =~ s:$pattern:$highlights{$pattern}:gs;\n";
		}