Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2df71b1a authored by Boaz Harrosh's avatar Boaz Harrosh Committed by James Bottomley
Browse files

[SCSI] osd_uld: Remove creation of osd_scsi class symlink 



Remove the creation of the symlink from the device to
it's class. On modern systems this is already created by
a udev rule and would WARN on load. On old systems it is
not needed, none of the current osd user-mode tools use
this link.

Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent 8c0bacca

drivers/scsi/osd/osd_uld.c

+0 −6
Original line number Diff line number Diff line
@@ -345,10 +345,6 @@ static int osd_probe(struct device *dev) 
	}



	dev_set_drvdata(oud->class_member, oud);

	error = sysfs_create_link(&scsi_device->sdev_gendev.kobj,

				  &oud->class_member->kobj, osd_symlink);

	if (error)

		OSD_ERR("warning: unable to make symlink\n");



	OSD_INFO("osd_probe %s\n", disk->disk_name);

	return 0;
@@ -377,8 +373,6 @@ static int osd_remove(struct device *dev) 
			scsi_device);

	}



	sysfs_remove_link(&oud->od.scsi_device->sdev_gendev.kobj, osd_symlink);



	if (oud->class_member)

		device_destroy(osd_sysfs_class,

			       MKDEV(SCSI_OSD_MAJOR, oud->minor));