Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2d7defb0 authored by Dan Carpenter's avatar Dan Carpenter Committed by Kalle Valo
Browse files

mwifiex: remove an unneede NULL check in mwifiex_init_adapter() 



"adapter->sleep_cfm" is always non-NULL at this point.  Static checkers
complain that we already dereference it at the start of the function
when we do:

	skb_put(adapter->sleep_cfm, sizeof(struct mwifiex_opt_sleep_confirm));

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarAmitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 2f5872b6

drivers/net/wireless/mwifiex/init.c

+9 −12
Original line number Diff line number Diff line
@@ -266,18 +266,15 @@ static void mwifiex_init_adapter(struct mwifiex_adapter *adapter) 


	mwifiex_wmm_init(adapter);



	if (adapter->sleep_cfm) {

	sleep_cfm_buf = (struct mwifiex_opt_sleep_confirm *)

					adapter->sleep_cfm->data;

	memset(sleep_cfm_buf, 0, adapter->sleep_cfm->len);

		sleep_cfm_buf->command =

				cpu_to_le16(HostCmd_CMD_802_11_PS_MODE_ENH);

		sleep_cfm_buf->size =

				cpu_to_le16(adapter->sleep_cfm->len);

	sleep_cfm_buf->command = cpu_to_le16(HostCmd_CMD_802_11_PS_MODE_ENH);

	sleep_cfm_buf->size = cpu_to_le16(adapter->sleep_cfm->len);

	sleep_cfm_buf->result = 0;

	sleep_cfm_buf->action = cpu_to_le16(SLEEP_CONFIRM);

	sleep_cfm_buf->resp_ctrl = cpu_to_le16(RESP_NEEDED);

	}



	memset(&adapter->sleep_params, 0, sizeof(adapter->sleep_params));

	memset(&adapter->sleep_period, 0, sizeof(adapter->sleep_period));

	adapter->tx_lock_flag = false;