Commit 2d4dda78 authored Jan 02, 2014 by Julia Lawall Committed by David S. Miller Jan 03, 2014

net: tulip: delete useless tests on netdev_priv

Netdev_priv performs an addition, not a pointer dereference, so it seems
quite unlikely that its result would ever be NULL.

A semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
statement S;
@@

- if (!netdev_priv(...)) S
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Grant Grundler <grundler@parisc-linux.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c1ddf295

drivers/net/ethernet/dec/tulip/uli526x.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -1192,9 +1192,6 @@ static int uli526x_suspend(struct pci_dev *pdev, pm_message_t state)

		ULI526X_DBUG(0, "uli526x_suspend", 0);

		if (!netdev_priv(dev))
		return 0;

		pci_save_state(pdev);

		if (!netif_running(dev))
		@@ -1228,9 +1225,6 @@ static int uli526x_resume(struct pci_dev *pdev)

		ULI526X_DBUG(0, "uli526x_resume", 0);

		if (!netdev_priv(dev))
		return 0;

		pci_restore_state(pdev);

		if (!netif_running(dev))