Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2c6083c5 authored by Gaurav Singhal's avatar Gaurav Singhal Committed by Gerrit - the friendly Code Review server
Browse files

NFC: Avoid VEN gpio toggle after boot 



VEN will be toggled from NFC driver only once
during boot, after that MW shouldn't modify it's state
as eSE is also powered using VEN gpio in SN100 NFC HW.

VEN toggle will reset eSE power and cause failure if
any communication is in progress.

Change-Id: Id1c75a47017e53cc9d597e8d307a80a667207f74
Signed-off-by: default avatarGaurav Singhal <gsinghal@codeaurora.org>
parent ebb15786

drivers/nfc/nq-nci.c

+0 −18
Original line number Original line Diff line number Diff line
@@ -488,25 +488,11 @@ int nfc_ioctl_power_states(struct file *filp, unsigned long arg) 
			usleep_range(10000, 10100);

			usleep_range(10000, 10100);

		}

		}





		if (gpio_is_valid(nqx_dev->ese_gpio)) {

			if (!gpio_get_value(nqx_dev->ese_gpio)) {

				dev_dbg(&nqx_dev->client->dev, "disabling en_gpio\n");

				gpio_set_value(nqx_dev->en_gpio, 0);

				usleep_range(10000, 10100);

			} else {

				dev_dbg(&nqx_dev->client->dev, "keeping en_gpio high\n");

			}

		} else {

			dev_dbg(&nqx_dev->client->dev, "ese_gpio invalid, set en_gpio to low\n");

			gpio_set_value(nqx_dev->en_gpio, 0);

			usleep_range(10000, 10100);

		}

		if (nqx_dev->pdata->clk_pin_voting) {

		if (nqx_dev->pdata->clk_pin_voting) {

			r = nqx_clock_deselect(nqx_dev);

			r = nqx_clock_deselect(nqx_dev);

			if (r < 0)

			if (r < 0)

				dev_err(&nqx_dev->client->dev, "unable to disable clock\n");

				dev_err(&nqx_dev->client->dev, "unable to disable clock\n");

		}

		}

		nqx_dev->nfc_ven_enabled = false;

	} else if (arg == 1) {

	} else if (arg == 1) {

		nqx_enable_irq(nqx_dev);

		nqx_enable_irq(nqx_dev);

		dev_dbg(&nqx_dev->client->dev,

		dev_dbg(&nqx_dev->client->dev,
@@ -516,8 +502,6 @@ int nfc_ioctl_power_states(struct file *filp, unsigned long arg) 
			gpio_set_value(nqx_dev->firm_gpio, 0);

			gpio_set_value(nqx_dev->firm_gpio, 0);

			usleep_range(10000, 10100);

			usleep_range(10000, 10100);

		}

		}

		gpio_set_value(nqx_dev->en_gpio, 1);

		usleep_range(10000, 10100);

		if (nqx_dev->pdata->clk_pin_voting) {

		if (nqx_dev->pdata->clk_pin_voting) {

			r = nqx_clock_select(nqx_dev);

			r = nqx_clock_select(nqx_dev);

			if (r < 0)

			if (r < 0)
@@ -887,8 +871,6 @@ static int nfcc_hw_check(struct i2c_client *client, struct nqx_dev *nqx_dev) 
		break;

		break;

	}

	}





	/*Disable NFC by default to save power on boot*/

	gpio_set_value(enable_gpio, 0);/* ULPM: Disable */

	ret = 0;

	ret = 0;

	goto done;

	goto done;