Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b129789 authored by Fabio Estevam's avatar Fabio Estevam Committed by Felipe Balbi
Browse files

usb: phy: ab8500-usb: Pass the IRQF_ONESHOT flag 



Since commit 1c6c6952 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.

Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 7cc99f1e

drivers/usb/phy/phy-ab8500-usb.c

+3 −3
Original line number Diff line number Diff line
@@ -1179,7 +1179,7 @@ static int ab8500_usb_irq_setup(struct platform_device *pdev, 
		}

		err = devm_request_threaded_irq(&pdev->dev, irq, NULL,

				ab8500_usb_link_status_irq,

				IRQF_NO_SUSPEND | IRQF_SHARED,

				IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,

				"usb-link-status", ab);

		if (err < 0) {

			dev_err(ab->dev, "request_irq failed for link status irq\n");
@@ -1195,7 +1195,7 @@ static int ab8500_usb_irq_setup(struct platform_device *pdev, 
		}

		err = devm_request_threaded_irq(&pdev->dev, irq, NULL,

				ab8500_usb_disconnect_irq,

				IRQF_NO_SUSPEND | IRQF_SHARED,

				IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,

				"usb-id-fall", ab);

		if (err < 0) {

			dev_err(ab->dev, "request_irq failed for ID fall irq\n");
@@ -1211,7 +1211,7 @@ static int ab8500_usb_irq_setup(struct platform_device *pdev, 
		}

		err = devm_request_threaded_irq(&pdev->dev, irq, NULL,

				ab8500_usb_disconnect_irq,

				IRQF_NO_SUSPEND | IRQF_SHARED,

				IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,

				"usb-vbus-fall", ab);

		if (err < 0) {

			dev_err(ab->dev, "request_irq failed for Vbus fall irq\n");