Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2aee7c5d authored by Eric Anholt's avatar Eric Anholt
Browse files

drm/vc4: Fix double destroy of the BO cache on teardown. 



It's also destroyed from the top level vc4_drv.c initialization, which
is where the cache was actually initialized from.

This used to just involve duplicate del_timer() and cancel_work_sync()
being called, but it started causing kmalloc issues once we
double-freed the new BO label array.

Fixes: 1908a876f909 ("drm/vc4: Add an ioctl for labeling GEM BOs for summary stats")
Signed-off-by: default avatarEric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20170802203242.12815-1-eric@anholt.net


Tested-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Acked-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Reviewed-by: default avatarBoris Brezillon <boris.brezillon@free-electrons.com>
parent 16fece01

drivers/gpu/drm/vc4/vc4_gem.c

+0 −2
Original line number Diff line number Diff line
@@ -1117,6 +1117,4 @@ vc4_gem_destroy(struct drm_device *dev) 


	if (vc4->hang_state)

		vc4_free_hang_state(dev, vc4->hang_state);



	vc4_bo_cache_destroy(dev);

}