Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2a8fa123 authored by Boris Ostrovsky's avatar Boris Ostrovsky Committed by Rafael J. Wysocki
Browse files

cpufreq: Remove CPU hotplug callbacks only if they were initialized 



Since CPU hotplug callbacks are requested for CPUHP_AP_ONLINE_DYN state,
successful callback initialization will result in cpuhp_setup_state()
returning a positive value. Therefore acpi_cpufreq_online being zero
indicates that callbacks have not been installed.

This means that acpi_cpufreq_boost_exit() should only remove them if
acpi_cpufreq_online is positive. Trying to call
cpuhp_remove_state_nocalls(0) will cause a BUG().

Signed-off-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 1358e038

drivers/cpufreq/acpi-cpufreq.c

+1 −1
Original line number Diff line number Diff line
@@ -930,7 +930,7 @@ static void __init acpi_cpufreq_boost_init(void) 


static void acpi_cpufreq_boost_exit(void)

{

	if (acpi_cpufreq_online >= 0)

	if (acpi_cpufreq_online > 0)

		cpuhp_remove_state_nocalls(acpi_cpufreq_online);

}