Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 299d0c5b authored by Brian Norris's avatar Brian Norris Committed by Richard Weinberger
Browse files

UBI: fix check for "too many bytes" 



The comparison from the previous line seems to have been erroneously
(partially) copied-and-pasted onto the next. The second line should be
checking req.bytes, not req.lnum.

Coverity CID #139400

Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
[rw: Fixed comparison]
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent f16db807

drivers/mtd/ubi/cdev.c

+1 −1
Original line number Diff line number Diff line
@@ -455,7 +455,7 @@ static long vol_cdev_ioctl(struct file *file, unsigned int cmd, 
		/* Validate the request */

		err = -EINVAL;

		if (req.lnum < 0 || req.lnum >= vol->reserved_pebs ||

		    req.bytes < 0 || req.lnum >= vol->usable_leb_size)

		    req.bytes < 0 || req.bytes > vol->usable_leb_size)

			break;



		err = get_exclusive(desc);