Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 29110630 authored by Markus Elfring's avatar Markus Elfring Committed by David S. Miller
Browse files

net: mvneta: Use devm_kmalloc_array() in mvneta_init() 



* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "devm_kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5f8ddeab

drivers/net/ethernet/marvell/mvneta.c

+5 −3
Original line number Original line Diff line number Diff line
@@ -4027,8 +4027,10 @@ static int mvneta_init(struct device *dev, struct mvneta_port *pp) 
		rxq->size = pp->rx_ring_size;

		rxq->size = pp->rx_ring_size;

		rxq->pkts_coal = MVNETA_RX_COAL_PKTS;

		rxq->pkts_coal = MVNETA_RX_COAL_PKTS;

		rxq->time_coal = MVNETA_RX_COAL_USEC;

		rxq->time_coal = MVNETA_RX_COAL_USEC;

		rxq->buf_virt_addr = devm_kmalloc(pp->dev->dev.parent,

		rxq->buf_virt_addr

						  rxq->size * sizeof(void *),

			= devm_kmalloc_array(pp->dev->dev.parent,

					     rxq->size,

					     sizeof(*rxq->buf_virt_addr),

					     GFP_KERNEL);

					     GFP_KERNEL);

		if (!rxq->buf_virt_addr)

		if (!rxq->buf_virt_addr)

			return -ENOMEM;

			return -ENOMEM;