Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2902fb7e authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Mauro Carvalho Chehab
Browse files

[media] stk1160: Try to continue with fewer transfer buffers 



Many people are trying to use stk1160 on low memory devices.
Instead of failing if one allocation fails, we allow the driver
to continue working if fewer transfer buffers are available.

Signed-off-by: default avatarEzequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 2948b0b3

drivers/media/usb/stk1160/stk1160-video.c

+21 −2
Original line number Diff line number Diff line
@@ -475,7 +475,11 @@ int stk1160_alloc_isoc(struct stk1160 *dev) 
		if (!dev->isoc_ctl.transfer_buffer[i]) {

			stk1160_err("cannot alloc %d bytes for tx[%d] buffer\n",

				sb_size, i);



			/* Not enough transfer buffers, so just give up */

			if (i < STK1160_MIN_BUFS)

				goto free_i_bufs;

			goto nomore_tx_bufs;

		}

		memset(dev->isoc_ctl.transfer_buffer[i], 0, sb_size);
@@ -506,13 +510,28 @@ int stk1160_alloc_isoc(struct stk1160 *dev) 
		}

	}



	stk1160_dbg("urbs allocated\n");

	stk1160_dbg("%d urbs allocated\n", num_bufs);



	/* At last we can say we have some buffers */

	dev->isoc_ctl.num_bufs = num_bufs;



	return 0;



nomore_tx_bufs:

	/*

	 * Failed to allocate desired buffer count. However, we may have

	 * enough to work fine, so we just free the extra urb,

	 * store the allocated count and keep going, fingers crossed!

	 */

	usb_free_urb(dev->isoc_ctl.urb[i]);

	dev->isoc_ctl.urb[i] = NULL;



	stk1160_warn("%d urbs allocated. Trying to continue...\n", i - 1);



	dev->isoc_ctl.num_bufs = i - 1;



	return 0;



free_i_bufs:

	/* Save the allocated buffers so far, so we can properly free them */

	dev->isoc_ctl.num_bufs = i+1;

drivers/media/usb/stk1160/stk1160.h

+3 −2
Original line number Diff line number Diff line
@@ -30,11 +30,12 @@ 
#define STK1160_VERSION		"0.9.5"

#define STK1160_VERSION_NUM	0x000905



/* TODO: Decide on number of packets for each buffer */

/* Decide on number of packets for each buffer */

#define STK1160_NUM_PACKETS 64



/* Number of buffers for isoc transfers */

#define STK1160_NUM_BUFS 16 /* TODO */

#define STK1160_NUM_BUFS 16

#define STK1160_MIN_BUFS 1



/* TODO: This endpoint address should be retrieved */

#define STK1160_EP_VIDEO 0x82