Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28de1f74 authored by Hariprasad S's avatar Hariprasad S Committed by Doug Ledford
Browse files

iw_cxgb4: Take clip reference before starting IPv6 listen 



The h/w is designed in such a way that, if you do anything IPv6
related, a valid clip entry must be there. So take clip reference
before creating IPv6 listening servers, and then if we fail to
create server, release the clip entry.

Signed-off-by: default avatarHariprasad Shenai <hariprasad@chelsio.com>
Acked-by: default avatarSteve Wise <swise@opengridcomputing.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 4275a5b2

drivers/infiniband/hw/cxgb4/cm.c

+10 −4
Original line number Diff line number Diff line
@@ -3271,6 +3271,12 @@ static int create_server6(struct c4iw_dev *dev, struct c4iw_listen_ep *ep) 
	struct sockaddr_in6 *sin6 = (struct sockaddr_in6 *)

				    &ep->com.mapped_local_addr;



	if (ipv6_addr_type(&sin6->sin6_addr) != IPV6_ADDR_ANY) {

		err = cxgb4_clip_get(ep->com.dev->rdev.lldi.ports[0],

				     (const u32 *)&sin6->sin6_addr.s6_addr, 1);

		if (err)

			return err;

	}

	c4iw_init_wr_wait(&ep->com.wr_wait);

	err = cxgb4_create_server6(ep->com.dev->rdev.lldi.ports[0],

				   ep->stid, &sin6->sin6_addr,
@@ -3282,13 +3288,13 @@ static int create_server6(struct c4iw_dev *dev, struct c4iw_listen_ep *ep) 
					  0, 0, __func__);

	else if (err > 0)

		err = net_xmit_errno(err);

	if (err)

	if (err) {

		cxgb4_clip_release(ep->com.dev->rdev.lldi.ports[0],

				   (const u32 *)&sin6->sin6_addr.s6_addr, 1);

		pr_err("cxgb4_create_server6/filter failed err %d stid %d laddr %pI6 lport %d\n",

		       err, ep->stid,

		       sin6->sin6_addr.s6_addr, ntohs(sin6->sin6_port));

	else

		cxgb4_clip_get(ep->com.dev->rdev.lldi.ports[0],

			       (const u32 *)&sin6->sin6_addr.s6_addr, 1);

	}

	return err;

}