Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28726286 authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman
Browse files

TTY: ntty, add one more sanity check 



With the previous patch, we fixed another bug where read_buf was freed
while we still was in n_tty_read. We currently check whether read_buf
is NULL at the start of the function. Add one more check after we wake
up from waiting for input.

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 92f6fa09

drivers/tty/n_tty.c

+1 −0
Original line number Diff line number Diff line
@@ -1815,6 +1815,7 @@ static ssize_t n_tty_read(struct tty_struct *tty, struct file *file, 
			/* FIXME: does n_tty_set_room need locking ? */

			n_tty_set_room(tty);

			timeout = schedule_timeout(timeout);

			BUG_ON(!tty->read_buf);

			continue;

		}

		__set_current_state(TASK_RUNNING);