Commit 2501c1bb authored Mar 06, 2017 by Chris Brandt Committed by Wolfram Sang Mar 08, 2017

i2c: riic: fix restart condition



While modifying the driver to use the STOP interrupt, the completion of the
intermediate transfers need to wake the driver back up in order to initiate
the next transfer (restart condition). Otherwise you get never ending
interrupts and only the first transfer sent.

Fixes: 71ccea09 ("i2c: riic: correctly finish transfers")
Reported-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
Tested-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

parent c1ae3cfa

drivers/i2c/busses/i2c-riic.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -218,8 +218,12 @@ static irqreturn_t riic_tend_isr(int irq, void *data)
		}

		if (riic->is_last \|\| riic->err) {
		riic_clear_set_bit(riic, 0, ICIER_SPIE, RIIC_ICIER);
		riic_clear_set_bit(riic, ICIER_TEIE, ICIER_SPIE, RIIC_ICIER);
		writeb(ICCR2_SP, riic->base + RIIC_ICCR2);
		} else {
		/* Transfer is complete, but do not send STOP */
		riic_clear_set_bit(riic, ICIER_TEIE, 0, RIIC_ICIER);
		complete(&riic->msg_done);
		}

		return IRQ_HANDLED;