Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 24c149ad authored by Jeff Layton's avatar Jeff Layton Committed by Ilya Dryomov
Browse files

ceph: fix bogus endianness change in ceph_ioctl_set_layout 



sparse says:

    fs/ceph/ioctl.c:100:28: warning: cast to restricted __le64

preferred_osd is a __s64 so we don't need to do any conversion. Also,
just remove the cast in ceph_ioctl_get_layout as it's not needed.

Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Reviewed-by: default avatarSage Weil <sage@redhat.com>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent 7fea24c6

fs/ceph/ioctl.c

+2 −2
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ static long ceph_ioctl_get_layout(struct file *file, void __user *arg) 
		l.stripe_count = ci->i_layout.stripe_count;

		l.object_size = ci->i_layout.object_size;

		l.data_pool = ci->i_layout.pool_id;

		l.preferred_osd = (s32)-1;

		l.preferred_osd = -1;

		if (copy_to_user(arg, &l, sizeof(l)))

			return -EFAULT;

	}
@@ -97,7 +97,7 @@ static long ceph_ioctl_set_layout(struct file *file, void __user *arg) 
		nl.data_pool = ci->i_layout.pool_id;



	/* this is obsolete, and always -1 */

	nl.preferred_osd = le64_to_cpu(-1);

	nl.preferred_osd = -1;



	err = __validate_layout(mdsc, &nl);

	if (err)