Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 248ac368 authored by Sylwester Nawrocki's avatar Sylwester Nawrocki Committed by Mauro Carvalho Chehab
Browse files

[media] s5p-fimc: Fix fimc-lite entities deregistration 



Clear the proper array when deregistering FIMC-LITE devices. Now
fimc[] array is erroneously accessed instead of fimc_lite[] and
fimc_md_unregister_entities() function call can result in an oops
from NULL pointer dereference, since fmd->fimc[] is cleared earlier.
This might happen in normal conditions when the driver's probing
is deferred and then retried.

Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent eb362092

drivers/media/platform/s5p-fimc/fimc-mdevice.c

+1 −1
Original line number Diff line number Diff line
@@ -472,7 +472,7 @@ static void fimc_md_unregister_entities(struct fimc_md *fmd) 
		if (fmd->fimc_lite[i] == NULL)

			continue;

		v4l2_device_unregister_subdev(&fmd->fimc_lite[i]->subdev);

		fmd->fimc[i]->pipeline_ops = NULL;

		fmd->fimc_lite[i]->pipeline_ops = NULL;

		fmd->fimc_lite[i] = NULL;

	}

	for (i = 0; i < CSIS_MAX_ENTITIES; i++) {