Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23853277 authored by Jens Axboe's avatar Jens Axboe
Browse files

block: remove unused REQ_UNPLUG 



The request inherits the unplug flag from the bio, but it isn't actually
used. The bio flag stops at __make_request(), which tells it to unplug
after submission. Passing it on to the request doesn't make any sense.

Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
parent 75e50984

block/blk-core.c

+0 −2
Original line number Diff line number Diff line
@@ -1123,8 +1123,6 @@ void init_request_from_bio(struct request *req, struct bio *bio) 


	if (bio_sync(bio))

		req->cmd_flags |= REQ_RW_SYNC;

	if (bio_unplug(bio))

		req->cmd_flags |= REQ_UNPLUG;

	if (bio_rw_meta(bio))

		req->cmd_flags |= REQ_RW_META;

	if (bio_noidle(bio))

include/linux/blkdev.h

+0 −2
Original line number Diff line number Diff line
@@ -117,7 +117,6 @@ enum rq_flag_bits { 
	__REQ_RW_META,		/* metadata io request */

	__REQ_COPY_USER,	/* contains copies of user pages */

	__REQ_INTEGRITY,	/* integrity metadata has been remapped */

	__REQ_UNPLUG,		/* unplug queue on submission */

	__REQ_NOIDLE,		/* Don't anticipate more IO after this one */

	__REQ_NR_BITS,		/* stops here */

};
@@ -145,7 +144,6 @@ enum rq_flag_bits { 
#define REQ_RW_META	(1 << __REQ_RW_META)

#define REQ_COPY_USER	(1 << __REQ_COPY_USER)

#define REQ_INTEGRITY	(1 << __REQ_INTEGRITY)

#define REQ_UNPLUG	(1 << __REQ_UNPLUG)

#define REQ_NOIDLE	(1 << __REQ_NOIDLE)



#define BLK_MAX_CDB	16