Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 21d0c833 authored by Herbert Xu's avatar Herbert Xu Committed by David S. Miller
Browse files

[PPP] pppoe: Fix double-free on skb after transmit failure 



When I got rid of the second packet in __pppoe_xmit I created
a double-free on the skb because of the goto abort on failure.
This patch removes that.

Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5588b40d

drivers/net/pppoe.c

+1 −2
Original line number Diff line number Diff line
@@ -879,8 +879,7 @@ static int __pppoe_xmit(struct sock *sk, struct sk_buff *skb) 
	dev->hard_header(skb, dev, ETH_P_PPP_SES,

			 po->pppoe_pa.remote, NULL, data_len);



	if (dev_queue_xmit(skb) < 0)

		goto abort;

	dev_queue_xmit(skb);



	return 1;