Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 21b031fb authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Greg Kroah-Hartman
Browse files

usb: musb: remove redundant stack buffers 



aDate is always the empty string, so entirely pointless. The aRevision
formatting might as well be done as part of the pr_debug() call - that
also avoids it altogether if pr_debug is compiled out.

Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: default avatarBin Liu <b-liu@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 48fed03b

drivers/usb/musb/musb_core.c

+5 −7
Original line number Diff line number Diff line
@@ -1448,7 +1448,7 @@ static int musb_core_init(u16 musb_type, struct musb *musb) 
{

	u8 reg;

	char *type;

	char aInfo[90], aRevision[32], aDate[12];

	char aInfo[90];

	void __iomem	*mbase = musb->mregs;

	int		status = 0;

	int		i;
@@ -1482,7 +1482,6 @@ static int musb_core_init(u16 musb_type, struct musb *musb) 


	pr_debug("%s: ConfigData=0x%02x (%s)\n", musb_driver_name, reg, aInfo);



	aDate[0] = 0;

	if (MUSB_CONTROLLER_MHDRC == musb_type) {

		musb->is_multipoint = 1;

		type = "M";
@@ -1497,11 +1496,10 @@ static int musb_core_init(u16 musb_type, struct musb *musb) 


	/* log release info */

	musb->hwvers = musb_read_hwvers(mbase);

	snprintf(aRevision, 32, "%d.%d%s", MUSB_HWVERS_MAJOR(musb->hwvers),

	pr_debug("%s: %sHDRC RTL version %d.%d%s\n",

		 musb_driver_name, type, MUSB_HWVERS_MAJOR(musb->hwvers),

		 MUSB_HWVERS_MINOR(musb->hwvers),

		 (musb->hwvers & MUSB_HWVERS_RC) ? "RC" : "");

	pr_debug("%s: %sHDRC RTL version %s %s\n",

		 musb_driver_name, type, aRevision, aDate);



	/* configure ep0 */

	musb_configure_ep0(musb);