Commit 2173bff5 authored Apr 03, 2012 by Shmulik Ladkani Committed by David S. Miller Apr 04, 2012

ipv6: Fix 'inet6_rtm_getroute' to release 'rt->dst' in case of 'alloc_skb' failure



In 72331bc0 [ipv6: Fix RTM_GETROUTE's interpretation of RTA_IIF to be
consistent with ipv4] the code of 'inet6_rtm_getroute()' was re-ordered
such that the reference to 'rt->dst' is incremented prior skb
allocation.

Hence, if 'alloc_skb()' fails, must drop a reference from 'rt->dst'.
Add the missing 'dst_release()' call.

Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7ebae817

net/ipv6/route.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2606,6 +2606,7 @@ static int inet6_rtm_getroute(struct sk_buff in_skb, struct nlmsghdr nlh, void

		skb = alloc_skb(NLMSG_GOODSIZE, GFP_KERNEL);
		if (!skb) {
		dst_release(&rt->dst);
		err = -ENOBUFS;
		goto errout;
		}