Commit 2149f66f authored Aug 20, 2009 by Patrick McHardy Committed by David S. Miller Aug 23, 2009

netfilter: xt_quota: fix wrong return value (error case)



Success was indicated on a memory allocation failure, thereby causing
a crash due to a later NULL deref.
(Affects v2.6.30-rc1 up to here.)

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ca6982b8

net/netfilter/xt_quota.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -52,7 +52,7 @@ static bool quota_mt_check(const struct xt_mtchk_param *par)

		q->master = kmalloc(sizeof(*q->master), GFP_KERNEL);
		if (q->master == NULL)
		return -ENOMEM;
		return false;

		q->master->quota = q->quota;
		return true;