Commit 20e7d465 authored Aug 07, 2014 by Julia Lawall Committed by Felipe Balbi Aug 19, 2014

usb: gadget: fix error return code

Convert a zero return value on error to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent bbc66e14

drivers/usb/gadget/udc/fusb300_udc.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -1398,13 +1398,17 @@ static int fusb300_probe(struct platform_device *pdev)

		/* initialize udc */
		fusb300 = kzalloc(sizeof(struct fusb300), GFP_KERNEL);
		if (fusb300 == NULL)
		if (fusb300 == NULL) {
		ret = -ENOMEM;
		goto clean_up;
		}

		for (i = 0; i < FUSB300_MAX_NUM_EP; i++) {
		_ep[i] = kzalloc(sizeof(struct fusb300_ep), GFP_KERNEL);
		if (_ep[i] == NULL)
		if (_ep[i] == NULL) {
		ret = -ENOMEM;
		goto clean_up;
		}
		fusb300->ep[i] = _ep[i];
		}