Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 20dcf8e2 authored by Al Viro's avatar Al Viro
Browse files

lpfc debugfs: get rid of pointless access_ok() 



copy_from_user() needs no protection - it does the checks itself

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 5a501193

drivers/scsi/lpfc/lpfc_debugfs.c

+0 −20
Original line number Original line Diff line number Diff line
@@ -1942,10 +1942,6 @@ lpfc_debugfs_nvmestat_write(struct file *file, const char __user *buf, 
	if (nbytes > 64)

	if (nbytes > 64)

		nbytes = 64;

		nbytes = 64;





	/* Protect copy from user */

	if (!access_ok(VERIFY_READ, buf, nbytes))

		return -EFAULT;



	memset(mybuf, 0, sizeof(mybuf));

	memset(mybuf, 0, sizeof(mybuf));





	if (copy_from_user(mybuf, buf, nbytes))

	if (copy_from_user(mybuf, buf, nbytes))
@@ -2026,10 +2022,6 @@ lpfc_debugfs_nvmektime_write(struct file *file, const char __user *buf, 
	if (nbytes > 64)

	if (nbytes > 64)

		nbytes = 64;

		nbytes = 64;





	/* Protect copy from user */

	if (!access_ok(VERIFY_READ, buf, nbytes))

		return -EFAULT;



	memset(mybuf, 0, sizeof(mybuf));

	memset(mybuf, 0, sizeof(mybuf));





	if (copy_from_user(mybuf, buf, nbytes))

	if (copy_from_user(mybuf, buf, nbytes))
@@ -2158,10 +2150,6 @@ lpfc_debugfs_nvmeio_trc_write(struct file *file, const char __user *buf, 
	if (nbytes > 64)

	if (nbytes > 64)

		nbytes = 64;

		nbytes = 64;





	/* Protect copy from user */

	if (!access_ok(VERIFY_READ, buf, nbytes))

		return -EFAULT;



	memset(mybuf, 0, sizeof(mybuf));

	memset(mybuf, 0, sizeof(mybuf));





	if (copy_from_user(mybuf, buf, nbytes))

	if (copy_from_user(mybuf, buf, nbytes))
@@ -2269,10 +2257,6 @@ lpfc_debugfs_cpucheck_write(struct file *file, const char __user *buf, 
	if (nbytes > 64)

	if (nbytes > 64)

		nbytes = 64;

		nbytes = 64;





	/* Protect copy from user */

	if (!access_ok(VERIFY_READ, buf, nbytes))

		return -EFAULT;



	memset(mybuf, 0, sizeof(mybuf));

	memset(mybuf, 0, sizeof(mybuf));





	if (copy_from_user(mybuf, buf, nbytes))

	if (copy_from_user(mybuf, buf, nbytes))
@@ -2343,10 +2327,6 @@ static int lpfc_idiag_cmd_get(const char __user *buf, size_t nbytes, 
	int i;

	int i;

	size_t bsize;

	size_t bsize;





	/* Protect copy from user */

	if (!access_ok(VERIFY_READ, buf, nbytes))

		return -EFAULT;



	memset(mybuf, 0, sizeof(mybuf));

	memset(mybuf, 0, sizeof(mybuf));

	memset(idiag_cmd, 0, sizeof(*idiag_cmd));

	memset(idiag_cmd, 0, sizeof(*idiag_cmd));

	bsize = min(nbytes, (sizeof(mybuf)-1));

	bsize = min(nbytes, (sizeof(mybuf)-1));