Commit 203f1c95 authored Aug 06, 2018 by David S. Miller Committed by Liangliang Lu Jan 30, 2019

lan78xx: Do not access skb_queue_head list pointers directly.



Use skb_queue_walk() instead.

Adjust inner loop test to utilize and skb_queue_is_first().
Unfortunately we have to keep pkt_cnt around because it is
used by a latter loop in this function.

Change-Id: I63159763bfaea0d29c3f4a0a26c47ab3f5f1dc33
Signed-off-by: David S. Miller <davem@davemloft.net>
Git-commit: e42a43a5cab2e019b5ab82bedb1340854709154d
Git-repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git


Signed-off-by: Liangliang Lu <luliang@codeaurora.org>

parent 7e529d1d

drivers/net/usb/lan78xx.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3188,9 +3188,9 @@ static void lan78xx_tx_bh(struct lan78xx_net *dev)
		count = 0;
		length = 0;
		spin_lock_irqsave(&tqp->lock, flags);
		for (skb = tqp->next; pkt_cnt < tqp->qlen; skb = skb->next) {
		skb_queue_walk(tqp, skb) {
		if (skb_is_gso(skb)) {
		if (pkt_cnt) {
		if (!skb_queue_is_first(tqp, skb)) {
		/* handle previous packets first */
		break;
		}