Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 20235f35 authored by Salyzyn, Mark's avatar Salyzyn, Mark Committed by James Bottomley
Browse files

[SCSI] aacraid: check buffer address in aac_internal_transfer 



Captured a panic on an older kernel where an application issuing
commands via sg was sending requests that lacked a request_buffer, thus
the buffer pointer used in aac_internal_transer was NULL. The
application was fixed closing the issue, but felt it was advised to
immunize the driver against the eventuality.

Signed-off-by: default avatarMark Salyzyn <aacraid@adaptec.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 0272bf72

drivers/scsi/aacraid/aachba.c

+3 −2
Original line number Diff line number Diff line
@@ -350,8 +350,9 @@ static void aac_internal_transfer(struct scsi_cmnd *scsicmd, void *data, unsigne 
		buf = scsicmd->request_buffer;

		transfer_len = min(scsicmd->request_bufflen, len + offset);

	}



	memcpy(buf + offset, data, transfer_len - offset);

	transfer_len -= offset;

	if (buf && transfer_len)

		memcpy(buf + offset, data, transfer_len);



	if (scsicmd->use_sg) 

		kunmap_atomic(buf - sg->offset, KM_IRQ0);