Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1fa8f450 authored by Mark Rustad's avatar Mark Rustad Committed by Nicholas Bellinger
Browse files

tcm_fc: Avoid debug overhead when not debugging 



Stop doing a pile of work related to debugging messages when
the ft_debug_logging flag is not set. Use unlikely to add the
check in a way that the check can be inlined without inlining the
whole thing.

Signed-off-by: default avatarMark Rustad <mark.d.rustad@intel.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 101998f6

drivers/target/tcm_fc/tcm_fc.h

+1 −0
Original line number Diff line number Diff line
@@ -131,6 +131,7 @@ extern struct list_head ft_lport_list; 
extern struct mutex ft_lport_lock;

extern struct fc4_prov ft_prov;

extern struct target_fabric_configfs *ft_configfs;

extern unsigned int ft_debug_logging;



/*

 * Fabric methods.

drivers/target/tcm_fc/tfc_cmd.c

+7 −1
Original line number Diff line number Diff line
@@ -48,7 +48,7 @@ 
/*

 * Dump cmd state for debugging.

 */

void ft_dump_cmd(struct ft_cmd *cmd, const char *caller)

static void _ft_dump_cmd(struct ft_cmd *cmd, const char *caller)

{

	struct fc_exch *ep;

	struct fc_seq *sp;
@@ -80,6 +80,12 @@ void ft_dump_cmd(struct ft_cmd *cmd, const char *caller) 
	}

}



void ft_dump_cmd(struct ft_cmd *cmd, const char *caller)

{

	if (unlikely(ft_debug_logging))

		_ft_dump_cmd(cmd, caller);

}



static void ft_free_cmd(struct ft_cmd *cmd)

{

	struct fc_frame *fp;