Commit 1f3f53ae authored Dec 17, 2011 by Rob Clark Committed by Tomi Valkeinen Jan 02, 2012

OMAPDSS: APPLY: fix NULL pointer deref when mgr is not set



extra_info_update_ongoing() goes through all overlays, but doesn't check
if the overlay is connected to a manager. This leads to a crash whenever
an overlay has been detached.

Add a check to skip the non-connected overlays.

Reported-by: Rob Clark <rob@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

parent 6ea9b317

drivers/video/omap2/dss/apply.c

+3 −0

Original line number	Original line	Diff line number	Diff line
	@@ -327,6 +327,9 @@ static bool extra_info_update_ongoing(void)
	ovl = omap_dss_get_overlay(i);		ovl = omap_dss_get_overlay(i);
	op = get_ovl_priv(ovl);		op = get_ovl_priv(ovl);

			if (!ovl->manager)
			continue;

	mp = get_mgr_priv(ovl->manager);		mp = get_mgr_priv(ovl->manager);

	if (!mp->enabled)		if (!mp->enabled)