Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1f2aab01 authored by Greg Ungerer's avatar Greg Ungerer
Browse files

m68knommu: fix broken ColdFire slice timer read_clk() code 



There is a race on reading the ColdFire slice timer current count and the
total clock count so far. Interrupts are off, and we may have just missed
getting a new timer wrap event interrupt. Check for this and adjust the
cycle count and current read count accordingly.

Also the slice timer counts down from the terminal count. So in read_clk()
we need take the current clock count away from the terminal count.

Reported-by: default avatarAlexander Stein <alexander.stein@systec-electronic.com>
Signed-off-by: default avatarGreg Ungerer <gerg@uclinux.org>
parent ec841187

arch/m68k/platform/coldfire/sltimers.c

+6 −3
Original line number Diff line number Diff line
@@ -98,16 +98,19 @@ static struct irqaction mcfslt_timer_irq = { 
static cycle_t mcfslt_read_clk(struct clocksource *cs)

{

	unsigned long flags;

	u32 cycles;

	u16 scnt;

	u32 cycles, scnt;



	local_irq_save(flags);

	scnt = __raw_readl(TA(MCFSLT_SCNT));

	cycles = mcfslt_cnt;

	if (__raw_readl(TA(MCFSLT_SSR)) & MCFSLT_SSR_TE) {

		cycles += mcfslt_cycles_per_jiffy;

		scnt = __raw_readl(TA(MCFSLT_SCNT));

	}

	local_irq_restore(flags);



	/* subtract because slice timers count down */

	return cycles - scnt;

	return cycles + ((mcfslt_cycles_per_jiffy - 1) - scnt);

}



static struct clocksource mcfslt_clk = {