Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e70bd46 authored by Charndeep Grewal's avatar Charndeep Grewal Committed by Greg Kroah-Hartman
Browse files

staging: android: logger: enforce GID and CAP check on log flush 



Restrict log flushing to those in the logs group, or
anyone with CAP_SYSLOG.

Cc: Android Kernel Team <kernel-team@android.com>
Cc: Charndeep Grewal <csgrewa@tycho.ncsc.mil>
Signed-off-by: default avatarCharndeep Grewal <csgrewa@tycho.ncsc.mil>
Signed-off-by: default avatarJohn Stultz <john.stultz@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0441bcf4

drivers/staging/android/logger.c

+5 −0
Original line number Diff line number Diff line
@@ -695,6 +695,11 @@ static long logger_ioctl(struct file *file, unsigned int cmd, unsigned long arg) 
			ret = -EBADF;

			break;

		}

		if (!(in_egroup_p(file->f_dentry->d_inode->i_gid) ||

				capable(CAP_SYSLOG))) {

			ret = -EPERM;

			break;

		}

		list_for_each_entry(reader, &log->readers, list)

			reader->r_off = log->w_off;

		log->head = log->w_off;