Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1d5fd003 authored by Michał Winiarski's avatar Michał Winiarski Committed by Chris Wilson
Browse files

drm/i915: Remove misleading comment in request_alloc 



Passing NULL ctx to request_alloc would lead to null-ptr-deref.

v2: Let's not replace the comment with a BUG_ON

Signed-off-by: default avatarMichał Winiarski <michal.winiarski@intel.com>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Link: http://patchwork.freedesktop.org/patch/msgid/20170523102400.9614-1-michal.winiarski@intel.com


Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
parent 48f1fc3a

drivers/gpu/drm/i915/i915_gem_request.c

+0 −3
Original line number Diff line number Diff line
@@ -538,9 +538,6 @@ submit_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state) 
 *

 * @engine: engine that we wish to issue the request on.

 * @ctx: context that the request will be associated with.

 *       This can be NULL if the request is not directly related to

 *       any specific user context, in which case this function will

 *       choose an appropriate context to use.

 *

 * Returns a pointer to the allocated request if successful,

 * or an error code if not.