Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1d0d8beb authored by John Johansen's avatar John Johansen Committed by Greg Kroah-Hartman
Browse files

apparmor: fix logging of the existence test for signals 



commit 98cf5bbff413eadf1b9cb195a7b80cc61c72a50e upstream.

The existence test is not being properly logged as the signal mapping
maps it to the last entry in the named signal table. This is done
to help catch bugs by making the 0 mapped signal value invalid so
that we can catch the signal value not being filled in.

When fixing the off-by-one comparision logic the reporting of the
existence test was broken, because the logic behind the mapped named
table was hidden. Fix this by adding a define for the name lookup
and using it.

Cc: Stable <stable@vger.kernel.org>
Fixes: f7dc4c9a ("apparmor: fix off-by-one comparison on MAXMAPPED_SIG")
Signed-off-by: default avatarJohn Johansen <john.johansen@canonical.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b18daa09

security/apparmor/include/sig_names.h

+3 −1
Original line number Diff line number Diff line
@@ -2,6 +2,8 @@ 


#define SIGUNKNOWN 0

#define MAXMAPPED_SIG 35

#define MAXMAPPED_SIGNAME (MAXMAPPED_SIG + 1)



/* provide a mapping of arch signal to internal signal # for mediation

 * those that are always an alias SIGCLD for SIGCLHD and SIGPOLL for SIGIO

 * map to the same entry those that may/or may not get a separate entry
@@ -56,7 +58,7 @@ static const int sig_map[MAXMAPPED_SIG] = { 
};



/* this table is ordered post sig_map[sig] mapping */

static const char *const sig_names[MAXMAPPED_SIG + 1] = {

static const char *const sig_names[MAXMAPPED_SIGNAME] = {

	"unknown",

	"hup",

	"int",

security/apparmor/ipc.c

+1 −1
Original line number Diff line number Diff line
@@ -174,7 +174,7 @@ static void audit_signal_cb(struct audit_buffer *ab, void *va) 
			audit_signal_mask(ab, aad(sa)->denied);

		}

	}

	if (aad(sa)->signal < MAXMAPPED_SIG)

	if (aad(sa)->signal < MAXMAPPED_SIGNAME)

		audit_log_format(ab, " signal=%s", sig_names[aad(sa)->signal]);

	else

		audit_log_format(ab, " signal=rtmin+%d",