Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1d05303c authored by Julia Lawall's avatar Julia Lawall Committed by Guenter Roeck
Browse files

hwmon: (adt7475) use permission-specific DEVICE_ATTR variants 



Use DEVICE_ATTR_RO for read only attributes and DEVICE_ATTR_RW for
read/write attributes. This simplifies the source code, improves
readbility, and reduces the chance of inconsistencies.

The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 2f2dbea6

drivers/hwmon/adt7475.c

+14 −14
Original line number Diff line number Diff line
@@ -856,14 +856,15 @@ static ssize_t set_pwmfreq(struct device *dev, struct device_attribute *attr, 
	return count;

}



static ssize_t show_pwm_at_crit(struct device *dev,

				struct device_attribute *devattr, char *buf)

static ssize_t pwm_use_point2_pwm_at_crit_show(struct device *dev,

					struct device_attribute *devattr,

					char *buf)

{

	struct adt7475_data *data = adt7475_update_device(dev);

	return sprintf(buf, "%d\n", !!(data->config4 & CONFIG4_MAXDUTY));

}



static ssize_t set_pwm_at_crit(struct device *dev,

static ssize_t pwm_use_point2_pwm_at_crit_store(struct device *dev,

					struct device_attribute *devattr,

					const char *buf, size_t count)

{
@@ -888,14 +889,14 @@ static ssize_t set_pwm_at_crit(struct device *dev, 
	return count;

}



static ssize_t show_vrm(struct device *dev, struct device_attribute *devattr,

static ssize_t vrm_show(struct device *dev, struct device_attribute *devattr,

			char *buf)

{

	struct adt7475_data *data = dev_get_drvdata(dev);

	return sprintf(buf, "%d\n", (int)data->vrm);

}



static ssize_t set_vrm(struct device *dev, struct device_attribute *devattr,

static ssize_t vrm_store(struct device *dev, struct device_attribute *devattr,

			 const char *buf, size_t count)

{

	struct adt7475_data *data = dev_get_drvdata(dev);
@@ -910,8 +911,8 @@ static ssize_t set_vrm(struct device *dev, struct device_attribute *devattr, 
	return count;

}



static ssize_t show_vid(struct device *dev, struct device_attribute *devattr,

			char *buf)

static ssize_t cpu0_vid_show(struct device *dev,

			     struct device_attribute *devattr, char *buf)

{

	struct adt7475_data *data = adt7475_update_device(dev);

	return sprintf(buf, "%d\n", vid_from_reg(data->vid, data->vrm));
@@ -1057,11 +1058,10 @@ static SENSOR_DEVICE_ATTR_2(pwm3_auto_point2_pwm, S_IRUGO | S_IWUSR, show_pwm, 
			    set_pwm, MAX, 2);



/* Non-standard name, might need revisiting */

static DEVICE_ATTR(pwm_use_point2_pwm_at_crit, S_IWUSR | S_IRUGO,

		   show_pwm_at_crit, set_pwm_at_crit);

static DEVICE_ATTR_RW(pwm_use_point2_pwm_at_crit);



static DEVICE_ATTR(vrm, S_IWUSR | S_IRUGO, show_vrm, set_vrm);

static DEVICE_ATTR(cpu0_vid, S_IRUGO, show_vid, NULL);

static DEVICE_ATTR_RW(vrm);

static DEVICE_ATTR_RO(cpu0_vid);



static struct attribute *adt7475_attrs[] = {

	&sensor_dev_attr_in1_input.dev_attr.attr,