Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c5ebaae authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

staging: vt6655: check too restrictive (off by one) 



key_len == MAX_KEY_LEN is valid but we return an error.

Introduced-by: 6b7200fe ('Staging: vt6655: memory corruption in check in wpa_set_wpadev()')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6e28024e

drivers/staging/vt6655/wpactl.c

+2 −2
Original line number Diff line number Diff line
@@ -202,8 +202,8 @@ int wpa_set_keys(PSDevice pDevice, void *ctx, bool fcpfkernel) 
	int uu, ii;



	if (param->u.wpa_key.alg_name > WPA_ALG_CCMP ||

	    param->u.wpa_key.key_len >= MAX_KEY_LEN ||

	    param->u.wpa_key.seq_len >= MAX_KEY_LEN)

	    param->u.wpa_key.key_len > MAX_KEY_LEN ||

	    param->u.wpa_key.seq_len > MAX_KEY_LEN)

		return -EINVAL;



	DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "param->u.wpa_key.alg_name = %d \n", param->u.wpa_key.alg_name);